search

SWIFTSIM / pipeline-configs

Configuration files for the `pipeline`, each for different simulation sub-grid models.
1 stars 9 forks source link

Updates in the stellar abundance plots! #262

Closed correac closed 1 year ago

correac commented 1 year ago

Given the new APOGEE data in the observational data repository we are now using the galactocentric distances to make distance cuts in the stellar abundance distributions. In the stellar abundances script we now apply radial & azimuthal cuts, and combine the stellar distributions to give less weight to stars in the solar vicinity. Preliminary plots of these changes are attached.

MgFe_test_plot OFe_test_plot NFe_test_plot CFe_test_plot

EvgeniiChaikin commented 1 year ago

@correac @MatthieuSchaller we can merge this PR as soon as the merge from https://github.com/SWIFTSIM/velociraptor-comparison-data/pull/178 is ready and after the observational data submodule has been updated correspondingly.

@correac given that the APOGEE data have now changed, do any of the APOGEE plots' captions require an update?

correac commented 1 year ago

Oh yes! I just updated the APOGEE plots' captions. I forgot about that. I think with the new APOGEE data in the observational repository, these changes are ready to be merged as well.

MatthieuSchaller commented 1 year ago

I have updated the observational data submodule in master.