search

SWIFTSIM / pipeline-configs

Configuration files for the `pipeline`, each for different simulation sub-grid models.
1 stars 9 forks source link

Updating metallicity.yml, removing [O/Fe] vs Mstellar plot #264

Closed correac closed 10 months ago

correac commented 11 months ago

Hello! Ignore the previous pull request. I think the tip of my remote repo was not right, which gave raise to the additional (unwanted) modification. Find the correct changes in this PR, where I am modifying the following file colibre/auto_plotter/metallicity.yml. I am adding the Romero-Gomez+ dataset that is already in the observational data repository. I am also deleting the [O/Fe] vs Stellar Mass plot, since the observational data to compare was not suite for it.

correac commented 11 months ago

Ah another thing Evgenii. Could you also update the ObservationalData submodule to the ddecf63 commit? I am not sure how to PR for that.

correac commented 10 months ago

@EvgeniiChaikin can you approve the PR?

EvgeniiChaikin commented 10 months ago

The new observational data seems to be going below M* = 1e7 Msun but the plot begins at 1e7 Msun

stellar_mass_star_mg_over_fe_50

Do you think we should extend the lower-mass limit to lower values?

Also, does anything need to be updated in the plots' captions?

correac commented 10 months ago

Yes, perhaps we can go down to 1e6 Msun, like the stellar mass- Fe/H plots. And now that I see it, the caption should be a bit more informative. Let me add a few lines.

correac commented 10 months ago

Okey @EvgeniiChaikin new caption :

"[Mg/Fe] versus stellar mass, both computed in 50-kpc apertures. The values of [Mg/Fe] are obtained by computing the (log10 of) ratio between the total Magnesium mass in stars and total Iron mass in stars, and then normalising it by the corresponding solar abundances. The solar abundances are taken from Asplund et al. (2009). All haloes are plotted, including subhaloes. Romero-Gomez+ dataset of ATLAS-3D galaxies has been corrected from Grevesse & Sauval (1998) to Aspund+ solar abundances. However Romero-Gomez dataset of dwarf galaxies, that corresponds to a compilation of [alpha/Fe] values from the dwarf spherical galaxies in the Local Group (Table B2 of Romero-Gomez et al. 2023), has not been corrected to Asplund+ solar abundances, this is pending and should be done for each individual data point. Gallazzi+ dataset should be corrected from Grevesse + (1991) to Asplund+ solar abundances. However a different [Fe/H] value is adopted (7.48 as opposed to 7.67) because we think that that value was used in the study, but confirmation from Gallazzi et al. is still pending on this."

Let me know if it is unclear.

correac commented 10 months ago

New figure with x-axis extended to 1e6 Msun