New plots to analyse Nitrogen abundance

SWIFTSIM / pipeline-configs

Configuration files for the `pipeline`, each for different simulation sub-grid models.

1 stars 9 forks source link

New plots to analyse Nitrogen abundance #265

Closed correac closed 9 months ago

correac commented 11 months ago

New plots for log10(C/O) vs 12+log10(O/H) and log10(N/O) vs 12+log10(O/H). The goal of these relations is to test the primary and secondary production channels of Nitrogen nucleosynthesis.

robjmcgibbon commented 11 months ago

Could you please also upload some images of the new plots

MatthieuSchaller commented 10 months ago

Is this still [WIP] ?

correac commented 10 months ago

@MatthieuSchaller I'm checking consistency in everything now since I have four merge requests (SOAP, velociraptor-python, pipeline-configs and observational_dataset). Between today and tomorrow I will remade a few plots and recheck all changes to remove the WIP.

MatthieuSchaller commented 10 months ago

Any news on this? Still WIP?

correac commented 9 months ago

New plots for log10(C/O) vs 12+log10(O/H) and log10(N/O) vs 12+log10(O/H). The new figures are shown below. @MatthieuSchaller @robjmcgibbon I reviewed the changes and I am happy, this PR can be merged if there are no outstanding issues.

correac commented 9 months ago

I am adding four new plots to this PR. I hope that's ok! The new plots correspond to the stellar abundance plots with some variations: (1) [N/O] vs [O/H], (2) [N/O] vs [Fe/H], (3) [C/O] vs [O/H], (4) [C/O] vs [Fe/H]. Find the new figures below.

robjmcgibbon commented 9 months ago

Perfect, all looks good to me! Are you happy to merge https://github.com/SWIFTSIM/velociraptor-comparison-data/pull/179? We need to update the submodule link before we merge this PR

correac commented 9 months ago

Yes! I am happy to merge https://github.com/SWIFTSIM/velociraptor-comparison-data/pull/179 . I reviewed it the other day and it looks good. Thank you Rob!!