james-trayford
commented
3 years ago Thanks, I'm looking at the pipeline now, btw I don't get notifications for these issues because I use this (@wmfw23) rather than the @jtrayford account (maybe it was me way in the past, but it's not associated with any email I use now)
For the cold gas plots - the plots don't seem to work for me out of the box which seems strange - velociraptor swiftsimio and swiftpipeline seem to be up to date. I get:
Unable to create plot stellar_mass_molecular_to_neutral_fraction_30 due to an error when trying to convert units. This likely means that you are trying to set the output units for your plot to something not dimensionally consistent with your catalogue. The error may also be in your registration file, if you are using one and this failure was on a figure using registered quantities
any ideas why this might be happening?
EvgeniiChaikin
Cold Gas Relations
Section to be handled by @jtrayford
[ ] Can we start the y-axis at 1e-4?
[ ] In the captions of all plots, "fraction" is ambiguous, in the literature it can e.g. be either M_H2/Mstar or M_H2/(Mstar+M_H2) and there are more possibilities. Please detail in every caption what is shown.
[ ] If the bottom row shows fractions of the kind X/tot instead of X/Y, then we cannot have values greater than unity. In that case please only extend the y-axis range to a value of 2 or so.
[ ] Suggested order and type of plots for cold gas relations (every quantity is a mass):
first row: (y-axis range: (HI+H2)/(HI+H2+star) versus star HI/(HI+H2) vs star H2/(HI+H2) vs star starforming/(starforming+star) vs star
second row: (HI+H2)/starforming vs star H2/starforming vs star HI/starforming vs star
third row: (HI+H2)/star vs sSFR HI/star vs sSFR H2/star vs sSFR starforming/star vs sSFR
fourth row: (HI+H2)/(HI+H2+star) vs Sigma_star (Sigma = surface density) HI/(HI+H2) vs Sigma_star H2/(HI+H2) vs Sigma_star starforming/(starforming+star) vs Sigma_star
and any plots that compare with data and are not included above. Other plots not mentioned can be omitted
Density-temperature plots
Section to be handled by @JBorrow
Dust mass function
Section to be handled by @JBorrow
Gas mass function
Section to be handled by @JBorrow
Histograms
Section to be handled by @JBorrow
Hydrogen phase density-temperature
Section to be handled by @JBorrow
Metallicity
Section to be handled by @JBorrow
[x] Is gas metallicity (O/H)? y-axis title suggests it is, but caption does not. It should be (O/H)
[x] Specify whether it is gas phase or includes dust. We only want gas phase, not sure if that has been corrected already.
[ ] Stellar metallicity should be [Fe/H].
Star formation rates
Section to be handled by @EvgeniiChaikin
[x] Stellar mass - SFR. Change to sSFR vs stellar mass (all galaxies).
[x] No need to show SFR divided by halo mass vs halo mass
Stellar birth densities
Section to be handled by @EvgeniiChaikin
Stellar mass function
Section to be handled by @JBorrow
Stellar mass-halo mass
Section to be handled by @EvgeniiChaikin
[x] Start with the centrals only plots
[x] Start with the plots where the y-axis shows ratios.
[x] As far as I am concerned we only need to show the plots where the y-axis shows ratios.
[x] Captions should clarify what M200 means (crit or mean).
Things to copy from the XL pipeline
Section to be handled by @JBorrow
[x] Ages.
[ ] Clarify how age is weighted.
Baryon fractions
Section to be handled by @JBorrow