Fix the bug in comparing runs with the same names at different z

SWIFTSIM / pipeline

Pipeline for rapidly analysing SWIFT simulation outputs, using swiftsimio and velociraptor-python

Other

1 stars 4 forks source link

Fix the bug in comparing runs with the same names at different z #18

Closed EvgeniiChaikin closed 3 years ago

EvgeniiChaikin commented 3 years ago

Hi @JBorrow,

I found a bug that does not allow comparing snapshots from the same run at different redshifts. I added comments to the lines of the code I modified so that it is clear why such comparisons would not work before and are possible now.

Just to illustrate, with my change I get the expected results, e.g.

stellar_mass_halo_mass_M200_centrals_100

EvgeniiChaikin commented 3 years ago

It is unclear to me why the Python-3.7 build fails. Should be unrelated to the code I modified.

JBorrow commented 3 years ago

Yeah don't worry about the failing tests, it's just astropy's stuff being silly.

JBorrow commented 3 years ago

Thanks!