search

SWIFTSIM / pipeline

Pipeline for rapidly analysing SWIFT simulation outputs, using swiftsimio and velociraptor-python
Other
1 stars 4 forks source link

read an autoplotter global mask variable from config file #25

Closed james-trayford closed 3 years ago

james-trayford commented 3 years ago

see also PRs https://github.com/SWIFTSIM/velociraptor-python/pull/68, https://github.com/SWIFTSIM/pipeline-configs/pull/130

JBorrow commented 3 years ago

Agree with all of Evgenii's comments.

EvgeniiChaikin commented 3 years ago

I tested this update (including 3 PRs) again and confirm that everything works as expected. I have nothing else to add.

I presume if nobody else wants to add anything, we can finally merge the 3 PRs dealing with the global masking.

What do you think @JBorrow?