SWIFTSIM / pipeline

Pipeline for rapidly analysing SWIFT simulation outputs, using swiftsimio and velociraptor-python
Other
1 stars 4 forks source link

Additional arguments - alternative implementation #9

Closed james-trayford closed 4 years ago

james-trayford commented 4 years ago

An alternate implementation of argument feeding for plotting scripts (relative to this), using yaml lists and cleaner parsing. Amended example and test scripts to demonstrate use.

JBorrow commented 4 years ago

This looks much better; I will get back to you on some more details and a review as soon as I can.

james-trayford commented 4 years ago

Yes please feel free to change the way scripts accept arguments as I'm sure you have more experience with this - I'm really just interested in having the functionality available in some form

JBorrow commented 4 years ago

I'm going to merge this as-is and then open another PR with my changes. I'll also add you as a contributor.