search

SWIFTSIM / swiftsimio

Python library for reading SWIFT data. Uses unyt and h5py.
GNU Lesser General Public License v3.0
18 stars 13 forks source link

Python 3.12 ? #181

Closed MatthieuSchaller closed 9 months ago

MatthieuSchaller commented 10 months ago

Are there any reasons why the installer refuses to deploy on python 3.12? Does the code need adapting for that version?

JBorrow commented 9 months ago

What error message do you get? That should not happen. We do not explicitly gate against it.

MatthieuSchaller commented 9 months ago

We do here: https://github.com/SWIFTSIM/swiftsimio/blob/55fe0061d6e41f25b2291a209439149f2cffeaaf/pyproject.toml#L17

JBorrow commented 9 months ago

That's not correct, that's just metadata. requires-python = ">3.8.0" is the important line.

JBorrow commented 9 months ago

Was that your only concern? Please let me know if the install actually breaks and we can fix it. On my end I do not think there are any problems.

MatthieuSchaller commented 9 months ago

I recall having had a problem with pip installation at the time of creating the issue but I can't recreate it on my machine.

It was when the local system switched all to 3.12 and created all kinds of problems. May have been fixed magically.

JBorrow commented 9 months ago

Likely due to incompatibilities in llvmlite and numba or something. Numba only recently supported 3.12 as there were a few changes.

JBorrow commented 9 months ago

P.S. tests now all run on 3.12 as well.