SWISS-MODEL / covid-19-Annotations-on-Structures

Mapping sequence data onto structures for the Covid-19 Biohackathon April 2020
https://github.com/virtual-biohackathons/covid-19-bh20/wiki/Annotations-on-Structures
MIT License
2 stars 8 forks source link

[WIP] Add solvent accessibility calculation #34

Closed mlgill closed 4 years ago

mlgill commented 4 years ago

Add per-residue solvent accessibility calculation. Code is here

Notes

Open questions for feedback

gtauriello commented 4 years ago

@mlgill @Ninjani following the conversation after https://github.com/SWISS-MODEL/covid-19-Annotations-on-Structures/issues/8#issuecomment-611939925.

I suppose that this will this be included in #29 ? It probably makes sense to have it in there as I consider the surface annotations mainly useful if we can combine them from different PDB-structures covering the same UniProt-sequence.

In terms of output-format an intermediate csv-representation for the surface accessibility makes sense and will allow to easily swap this implementation with any other implementation computing the same values. Also conda environment file should be sufficient yes.

mlgill commented 4 years ago

@gtauriello Thanks for the feedback -- at this point, I agree that it makes sense to combine this work with #29 . I'll close this issue to keep things tidy -- please post any additional comments / feedback there.

Regarding the CSVs, I'll leave that as an intermediate output. I'll pull the new changes that @Ninjani has made and work on finalizing the annotation upload part after tending to some family issues.