Open sebastian-c opened 8 years ago
I took a look at the LSPR items. As far as I can tell, there is food for these elements. That doesn't make any sense as they're animals (Cattle, Sheep, Goats, Swine/pigs). Unless we're calculating the FBS for giants who eat animals whole, it doesn't make sense to me that this should should be in it.
I beg to differ.
Further examination of Cattle, Sheep Goats and Swine/Pigs reveals that they always end up with a Production of 0 and their Food value standardized to 0. This has one exception: Japan (392).
Further inspection shows me that there's no food data for these - they're being standardised up from meat. I'll need to check if the extraction rate matches up with converting meat to mammal.
I'm not confident the the module handles this situation well at all. I have the following report for Japan livestock commodities:
Initial SUA table:
Item | Production | Imports | Exports | StockChange | Food | Food Processing | Feed | Seed | Tourist | Industrial | Loss |
---|---|---|---|---|---|---|---|---|---|---|---|
21111.01 | 518,600 | - | - | - | - | - | - | - | - | - | - |
21113.01 | 1,297,000 | - | - | - | - | - | - | - | - | - | - |
21115 | 160 | - | - | - | - | - | - | - | - | - | - |
21116 | 50 | - | - | - | - | - | - | - | - | - | - |
21514 | 15 | - | - | - | - | - | - | - | - | - | - |
SUA table after processing forward:
Item | Production | Imports | Exports | StockChange | Food | Food Processing | Feed | Seed | Tourist | Industrial | Loss |
---|---|---|---|---|---|---|---|---|---|---|---|
21111.01 | 518,600 | - | - | - | - | - | - | - | - | - | - |
21113.01 | 1,297,000 | - | - | - | - | - | - | - | - | - | - |
21115 | 160 | - | - | - | - | - | - | - | - | - | - |
21116 | 50 | - | - | - | - | - | - | - | - | - | - |
21514 | 15 | - | - | - | - | - | - | - | - | - | - |
SUA table after balancing processed elements:
Item | Production | Imports | Exports | StockChange | Food | Food Processing | Feed | Seed | Tourist | Industrial | Loss |
---|---|---|---|---|---|---|---|---|---|---|---|
21111.01 | 518,600 | - | - | - | 518,600 | - | - | - | - | - | - |
21113.01 | 1,297,000 | - | - | - | 1,297,000 | - | - | - | - | - | - |
21115 | 160 | - | - | - | 160 | - | - | - | - | - | - |
21116 | 50 | - | - | - | 50 | - | - | - | - | - | - |
21514 | 15 | - | - | - | 15 | - | - | - | - | - | - |
Availability of parents/children:
measuredItemChildCPC | measuredItemParentCPC | extractionRate | availability |
---|---|---|---|
02951.01 | 02111 | 1 | NA |
02953 | 02122 | 1 | NA |
02954 | 02123 | 1 | NA |
02959.01 | 02140 | 1 | NA |
21111.01 | 02111 | 1 | NA |
21113 | 02140 | 1 | NA |
21113.01 | 02140 | 1 | NA |
21115 | 02122 | 1 | NA |
21116 | 02123 | 1 | NA |
21151 | 02111 | 1 | NA |
21153 | 02140 | 1 | NA |
21155 | 02122 | 1 | NA |
21156 | 02123 | 1 | NA |
21511.01 | 02140 | 1 | NA |
21512 | 02111 | 1 | NA |
21514 | 02122 | 1 | NA |
21515 | 02123 | 1 | NA |
SUA table after standardization:
Item | Production | Imports | Exports | StockChange | Food | Food Processing | Feed | Seed | Tourist | Industrial | Loss | Calories | Proteins | Fats |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
02111 | - | 0 | 0 | 0 | 1,355,900 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
02122 | - | 0 | 0 | 0 | 180 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
02123 | - | 0 | 0 | 0 | 50 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
02140 | - | 0 | 0 | -58,300 | 1,941,600 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
SUA table after balancing:
Item | Production | Imports | Exports | StockChange | Food | Food Processing | Feed | Seed | Tourist | Industrial | Loss | Calories | Proteins | Fats |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
02111 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
02122 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
02123 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
02140 | 0 | 0 | 0 | -60,000 | 60,000 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
SUA table with updated nutrient values:
Item | Production | Imports | Exports | StockChange | Food | Food Processing | Feed | Seed | Tourist | Industrial | Loss | Calories | Proteins | Fats |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
02111 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
02122 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
02123 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
02140 | 0 | 0 | 0 | -60,000 | 60,000 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
Temporarily fixed the issue in 190e6acc9dbb918a6084a2aa3ae6d9fc4b7e3bf6
This issue will be considered solved when the current fbsTree is replaced by the one provided by Veronica.
The current output of the module is in SUA CPC codes. This has a few consequences.
Changing to FBS codes would involve
fbsCodes
tableelementCodes.csv
):