search

SWS-Methodology / faoswsTrade

World trade data processing for the FAO Statistical Working System
http://www.fao.org/economic/ess/ess-home/en/
5 stars 2 forks source link

There should be a way to run modules for single countries #129

Open chrMongeau opened 7 years ago

chrMongeau commented 7 years ago

Let's say there is a revision of the data for all years for a specific country. With the current design of modules, all countries need to be updated and the process requires (long) time. In other words, there is not a way to run a module for a specific country. We should think about implementing a way to run the module for a single country.

malexan commented 7 years ago

The question is in additional filter during raw trade data reading and in games with area codes, right?

BTW, currently there are two additional parameters in the main.R: logical stopaftermapping and numeric samplesize for ES data (if it is NULL, it is not applied - default) - should be extended to TL as well.

chrMongeau commented 7 years ago

The question is in additional filter during raw trade data reading [...]

Yes, though I think that just filtering is not sufficient (e.g., the remaining countries would be considered as nonreporters, but in this case we don't really care about "nonreporters").

[...] and in games with area codes, right?

Mmh, I don't fully understand this :/

stopaftermapping and samplesize [...] should be extended to TL as well.

Just samplesize should be used also in TL, right?

Oh, about other parameters: debughsfclmap is used only in vignettes/preanalysis_2009.Rmd and vignettes/producingSet_new.Rmd (and related "producingSet" docs). I think we can get rid of it.

malexan commented 7 years ago

area code games

When to specify the area to work on, we will use fcl code. Then the algorithm should detect is it comes from TL or ES, then to convert to the corresponding area classification (m49|geonom) and to extract from the source.

Just samplesize should be used also in TL, right?

Yes

debughsfclmap

So it is used! :) Yep, let's remove it.