search

SWS-Methodology / tradeValidationTool

Trade validation tool
0 stars 0 forks source link

Add the actual correction input #1

Open chrMongeau opened 7 years ago

chrMongeau commented 7 years ago

Currently (as of 2018-08-24), corrections_table has the following variables:

> names(corrections_table)
 [1] "reporter"         "partner"          "year"             "item"             "flow"            
 [6] "data_original"    "data_type"        "correction_level" "correction_hs"    "correction_input"
[11] "correction_type"  "correction_note"  "note_analyst"     "note_supervisor"  "name_analyst"    
[16] "name_supervisor"  "date_correction"  "date_validation"

In particular, correction_input has the figure that is meant to replace data_original. The name is very ambiguous, as, from the name, one could assume that it's the input used for the correction (not the corrected data itself). It's probably better to add a variable called data_correct to store corrected values and use correction_input for storing the inputs used in the corrections. For instance, if a series is corrected by using the median unit value, thi should go in correction_input.