search

SWU-Karabast / SWUOnline

Star Wars Unlimited Sim
GNU General Public License v3.0
41 stars 32 forks source link

Link resource to DJ effect, #273

Closed Raising closed 1 month ago

Raising commented 1 month ago

save the resource card Id in the turn effect then use that info to only return such card if is still in the resources

OotTheMonk commented 1 month ago

Hi there! This approach looks really good! Is it possible to use the existing current turn effect search function instead of creating a new one? image

Raising commented 1 month ago

Hi!, the problem with the SearchCurrentTurnEffects is that only returns true or false, does not provide acces to the values stored in the turn effect. I'd rather refactor SearchCurrentTurnEffects to work as the one I propose but then youll have to test sightly diferent wherever it is used.

So in order to keep the impact of the PR as low impact as posible I created the new , almost identical, function.