search

SWViewer / tool-swviewer

https://swviewer.toolforge.org/
Other
16 stars 4 forks source link

All links should be links #51

Open stjohann opened 1 year ago

stjohann commented 1 year ago

Currently, <div id="userLinkSpec" ng-click="openLink('diff');" style="color: rgb(51, 102, 187);">AlwynapHuw</div> and <div id="pageLinkSpec" style="cursor: pointer; display: inline-block; color: var(--link-color); border-bottom: unset;" ng-click="openLink('page');">Help:Navigation/cy</div> are coded to behave like links that open in new window, but are not actually links. They should just be links like <a href="…" target="_blank">. Doing otherwise is an accessibility violation and makes the usability of the tool worse (since you can’t do any of the browser actions that are available to links with those links).

There might be other links I did not see in the application that are coded in the same way.

kfiven commented 1 year ago

In which part you found this link?

stjohann commented 1 year ago

At the top of diff view for any edit, of course. But you can search yourself in the codebase by looking up openLink or userLinkSpec or pageLinkSpec.