SWY1985 / CivOne

An open source implementation of Sid Meier's Civilization.
http://www.civone.org/
Creative Commons Zero v1.0 Universal
244 stars 49 forks source link

After my 1st unit destroys an enemy unit the game switches to 2nd unit #323

Closed axx0 closed 7 years ago

axx0 commented 7 years ago

even though my 1st unit still has some turns left.

SWY1985 commented 7 years ago

Linked to #280 I've tried finding out what causes this but it's very hard to pin point.

AlexFolland commented 7 years ago

This is the same bug as https://github.com/SWY1985/CivOne/issues/300, which was closed but I can't find the commit that fixed it.

SWY1985 commented 7 years ago

Issue #300 got closed because I thought it was solved. The unit doesn't lose the rest of their turns, it just loses focus, like the Wait order was given directly after attacking. This issue has my main focus as it's the most annoying bug there is at the moment. Hopefully I can solve it soon.

AlexFolland commented 7 years ago

Oh. When I reported it, the unit had actually lost all the rest of its movements after destroying an enemy unit on its first movement. Clicking it to activate it did not work.

AlexFolland commented 7 years ago

Also, sorry, I still have yet to go and play another game of CivOne for testing these things. I've been distracted with playing another fun/silly game, but I am still excited to get back to testing CivOne more.

AlexFolland commented 7 years ago

This might have been fixed when https://github.com/SWY1985/CivOne/issues/300 was fixed. @kazgaroth011, can you confirm? The problem was that attacking was removing movement points based on the enemy unit's tile's terrain type.

SWY1985 commented 7 years ago

This issue is not resolved, and I still have no idea what causes it. To be continued...

SWY1985 commented 7 years ago

I have figured out why this happens, solution on the way...