search

SWY1985 / CivOne

An open source implementation of Sid Meier's Civilization.
http://www.civone.org/
Creative Commons Zero v1.0 Universal
244 stars 49 forks source link

Enemy units in the city appear as having city walls #324

Closed axx0 closed 7 years ago

axx0 commented 7 years ago

Attacking an enemy unit in the city without city walls gives the unit a black border (pic below), but this should be the case only when the city has city walls.

clipboard02

SWY1985 commented 7 years ago

This is the same issue as #294

AlexFolland commented 7 years ago

How so? This doesn't seem to be the same as that issue to me. The other issue is about the unit appearing at all when attacking and losing the combat.

SWY1985 commented 7 years ago

The unit in the city is becoming visible including its fortification, when it shouldn't. The unit fortification graphic is the same as the City Walls graphic, that's why it looks like the city has City Walls. This issue will be solved once #294 is solved.

AlexFolland commented 7 years ago

They're still 2 completely different issues. This one is about the unit being visible at all times and https://github.com/SWY1985/CivOne/issues/294 is about the unit not appearing during the attack animation when losing the attack. I don't see how they're related. It just doesn't make sense to me. Anyway, it doesn't matter, if you say fixing one will solve the other.

SWY1985 commented 7 years ago

For clarity, I'll reopen this issue until both are fixed.

SWY1985 commented 7 years ago

This is a picture of a non-city wall attack on a city in the orignal game: image

The unit should be 1 pixel to the right and 1 pixel down, other than that the current behaviour is correct.

AlexFolland commented 7 years ago

Enemy units that win the combat are shown with "F" and without the city walls look, but with the city walls look when they lose the combat.

Edit: Never mind. I just saw an enemy Phalanx in a city with "F" on it even though my Cannon unit won the combat.