SWY1985 / CivOne

An open source implementation of Sid Meier's Civilization.
http://www.civone.org/
Creative Commons Zero v1.0 Universal
245 stars 49 forks source link

Railroad does not improve resource gains on tiles #331

Closed AlexFolland closed 7 years ago

AlexFolland commented 7 years ago

The railroaded and irrigated grassland tile in this screenshot should be providing 4 food under democracy, but is only providing 3.

image

This screenshot is to prove that it is grassland.

image

AlexFolland commented 7 years ago

The same is true on the plains tile in this screenshot. It should be providing 3 food, but is only providing 2.

image

AlexFolland commented 7 years ago

This railroaded mined coal hills tile should produce 7 production.

image

According to this page, https://www.civfanatics.com/civ1/refcharts/civ1terchart.htm , railroad increases food and production on a tile by 50%, rounded down. So, 2 more production from 5, 1 more food from 2 or 3, 2 more food from 4 (irrigated oasis).

SWY1985 commented 7 years ago

I'm going to test this against the original game. If you find any more errors like this, please post them here.

AlexFolland commented 7 years ago

Mined hills should give 1 extra production, irrigated hills should give 1 extra food, etc. Railroad's benefit, according to that chart, is this:

"Railroads increase food and resource production in a map square by 1/2 (rounded down). They increase trade by the same amount, but before the effects of Republic or Democracy governments."

That sounds right to me.

SWY1985 commented 7 years ago

I had not implemented gains from RailRoads at all... so that's the reason.

AlexFolland commented 7 years ago

There seems to be some sort of error here. A mined coal hills tile produces 5 production without a railroad. With a railroad, it should produce 7 production. Instead, it is producing 6.

My government is Despotism now, so it's possible that it should produce 6 instead due to that. I'll check. Online research wasn't much help here.

image

SWY1985 commented 7 years ago

With Anarchy and Despotism, the base value is 4 instead of 5: image

So 6 is correct in this case.

AlexFolland commented 7 years ago

My mistake then! Thanks.