search

SWY1985 / CivOne

An open source implementation of Sid Meier's Civilization.
http://www.civone.org/
Creative Commons Zero v1.0 Universal
245 stars 49 forks source link

Regression: Enter doesn't work on autosave screen #343

Closed AlexFolland closed 7 years ago

AlexFolland commented 7 years ago

Pressing main enter or numpad enter saves the game here, but doesn't continue to the next screen. See the stdout log in this screenshot.

image

SWY1985 commented 7 years ago

That's strange, it works for me and I tested this really well. Don't you get a save confirmation dialog?

AlexFolland commented 7 years ago

This appeared at 2000 BC and what you see in the screenshot is what I saw. Pressing enter made that line appear in stdout, but nothing else. Pressing escape exited this screen back to the game.

AlexFolland commented 7 years ago

For the record, I was using 9aa6d07070eacfd79f3139601cd13ee17abcb808 in this screenshot.

SWY1985 commented 7 years ago

Thanks for the information, I still can not reproduce this but I'll keep trying.

AlexFolland commented 7 years ago

I will tell you if it happens again, also, and try to give more detail in that case.

AlexFolland commented 7 years ago

It could have something to do with "End of Turn" being enabled. I always enable it, and I noticed that it is disabled by default.

AlexFolland commented 7 years ago

Yeah, it happened again at 1000 BC, and I definitely have "End of Turn" enabled. I can't think of any other details to mention.

Oh, I got a technology on the same turn, if that matters.

SWY1985 commented 7 years ago

Can you set breakpoints in /src/Screens/SaveGame.cs at lines 97, 120, 169, 191 and and see if any of them are ever hit. If so, please make a screenshot of VScode.

AlexFolland commented 7 years ago

I'm running without debugging, as running with debugging doesn't work here.

SWY1985 commented 7 years ago

Ah... okay. Does saving via the game menu work for you?

AlexFolland commented 7 years ago

If the stdout lines are correct, yes, but no, pressing enter while the file I want to overwrite is highlighted doesn't do anything visually inside the game window. Clicking also doesn't work.

image

SWY1985 commented 7 years ago

I have tried running the game on Windows 7 still can't reproduce this issue.

AlexFolland commented 7 years ago

It worked previously, so it must be something that was changed.

SWY1985 commented 7 years ago

There's a change: I have added a confirmation dialog. I'm going to keep trying to find out what could cause this...

SWY1985 commented 7 years ago

I can finally reproduce this...

SWY1985 commented 7 years ago

Is this possibly related to the invalid save games?

SWY1985 commented 7 years ago

There's been some more fixes to the Save games, including data validation on existing save games. The one situation where I could reproduce this had to do with corrupt save games. This appears to have been solved. Can you test to see if it works now? If not, can you try saving to another 'drive letter'?

AlexFolland commented 7 years ago

I can't test this adequately until https://github.com/SWY1985/CivOne/issues/384 is resolved.

AlexFolland commented 7 years ago

This seems to be fixed.

SWY1985 commented 7 years ago

Great news, thank you for testing! 👍