SWY1985 / CivOne

An open source implementation of Sid Meier's Civilization.
http://www.civone.org/
Creative Commons Zero v1.0 Universal
245 stars 49 forks source link

Railroad trade gain is calculated after Democracy bonus, giving too much trade #354

Closed AlexFolland closed 7 years ago

AlexFolland commented 7 years ago

Here is a screenshot of Civilization with a worker on a fully improved grassland tile (bottom middle).

image

Here is a screenshot of CivOne with fully improved grassland tiles, getting 1 extra trade on each.

image

The government is Democracy in both screenshots. According to the reference chart, "Railroads increase food and resource production in a map square by 1/2 (rounded down). They increase trade by the same amount, but before the effects of Republic or Democracy governments.", so the calculation adding trade should happen before the trade bonus from Republic or Democracy governments.