SWY1985 / CivOne

An open source implementation of Sid Meier's Civilization.
http://www.civone.org/
Creative Commons Zero v1.0 Universal
245 stars 49 forks source link

End-game sequence didn't appear upon conquering all enemy civilizations #358

Closed AlexFolland closed 7 years ago

AlexFolland commented 7 years ago

I was unsure if I'd conquered every civilization, so I made sure to explore the entire world map to find any enemy cities. There were no enemy cities left, yet the end-game sequence never started.

image

The year in this screenshot is 20 BC. It was somewhere around 500 BC that I conquered the last enemy city. I'm not sure exactly when though.

image

SWY1985 commented 7 years ago

There was a condition where cities of size 0 (destroyed cities) were still counted as cities owned by a certain player. This caused a failure to detect whether a civilization was destroyed. This condition has been fixed.