search

SWY1985 / CivOne

An open source implementation of Sid Meier's Civilization.
http://www.civone.org/
Creative Commons Zero v1.0 Universal
244 stars 49 forks source link

Improvements placed on ocean on random map #445

Open uHappyLogic opened 6 years ago

uHappyLogic commented 6 years ago

After creating a random map, some land improvements are placed in the ocean. Save is in zip attachment

save.zip

capture

SWY1985 commented 6 years ago

That's odd, how often does this happen?

uHappyLogic commented 6 years ago

I tried to reproduce this bug (several random maps with save/load game) but without success.

axx0 commented 6 years ago

It happened to me when I loaded a game. It puts saved game irrigation into a wrong tile when you load the game. On this pictures the irrigation is offset 3 tiles to the right. capture6

SWY1985 commented 6 years ago

So this only happens when loading a saved game, not on starting a new game? I'm currently working on getting load/save games fixes, so I'll try to fix this as well.

axx0 commented 6 years ago

I never noticed this happening when starting a game. EDIT: BTW this irrigation bug really messes things up. My city has shrunk to size 1 and cannot grow beyond size 2. The food needs calculation in the city seems to be way off.

SWY1985 commented 6 years ago

The problem seems to be that, not the improvements, but the map moves around when saving a game. I am able to reproduce it, so I'll be able to fix it soon.

SWY1985 commented 6 years ago

Suddenly, I can no longer reproduce this. I either accidentally fixed it, or this happens under certain conditions. Either way, it's confusing because this only happens sometimes.

If anyone can help me reproduce this, that would be extremely helpful. When this happens again, can you please post the save game files here? Thank you!

SWY1985 commented 6 years ago

I'm going to remove this from the target list of Alpha 1, until we find a way to reproduce this.

EnockNitti commented 5 years ago

Can repeat this problem. A bug in the RLE Encode() function at some unusual combination of input data