Cleanup SuffixArray getters

SYSTRAN / fuzzy-match

Library and command line utility to do approximate string matching of a source against a bitext index and get matched source and target.

MIT License

45 stars 8 forks source link

Closed guillaumekln closed 3 years ago

guillaumekln commented 3 years ago

operator[]: it's not immediately clear what is being indexed. We should use get_sentence or get_suffix instead.
sentence_buffer: this buffer should remain private
suffixid2sentenceid: the name is incorrect since it maps to SuffixView objects not sentence IDs, and we don't need to return the full vector.
nsentences: this small getter should be implemented in a header file.