SaaShup / netbox-docker-agent

Agent for Netbox Docker Plugin
https://saashup.com
BSD 3-Clause "New" or "Revised" License
33 stars 1 forks source link

:children_crossing: Starting a container while it is being recreated fails #55

Closed linkdd closed 5 months ago

linkdd commented 6 months ago
Netbox Version Plugin Version Agent Version
3.6.9 1.3.0 0.12.1

Actual Behavior

While a container is being created, clicking on the "Start" will results in an error:

{"message": "No such container: <container name>"}

Desired Behavior

Actions performed on a container should be queued. This means that clicking on the "Start" button should wait for the container to be created before actually starting the container.

lvenier commented 6 months ago

I believe this feature should be done on the plugin.

We should not be able to use an image for a container as long as imageID is not set.

linkdd commented 6 months ago

Another use case: I am an impatient child who is clicking frenetically the "Recreate" button 🤣

If you consider #54, it is possible that many quick updates (done via CI or via an Ansible playbook that do not care about checking the journal entries to wait for things) would queue many actions at once. With a queue, everything will be done smoothly, without a queue all hell breaks loose.