SaaShup / netbox-docker-plugin

Netbox Docker Plugin

https://saashup.com

BSD 3-Clause "New" or "Revised" License

65 stars 5 forks source link

:wrench: Enable update trigger on Image Webhook #129

Closed linkdd closed 5 months ago

linkdd commented 5 months ago

Decision Record

When the agent fails to pull an image (could be because of a temporary network issue), we have to delete it and recreate it to trigger the webhook again.

Let's enable the webhook for updates as well, so that saving the failed image triggers the webhook, enabling us to retry pulling.

NB: If the size of the image is not 0, the agent will ignore it, so successfully pulled image will still be a "NO-OP".

Changes

[x] :recycle: Update webhooks after migrations
[x] :wrench: Enable update trigger on Image Webhook

github-actions[bot] commented 5 months ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status

2292 2254 98% 90% ✅

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 75f93be by action🐍

Lines	Covered	Coverage	Threshold	Status
2292	2254	98%	90%	✅

fanshan commented 5 months ago

@linkdd Many thanks!

Why changing the webhook creation logic (we don't update webhook if it's already exists)?

linkdd commented 5 months ago

update_or_create was easier and clearer than:

filter
if found create
else filter+update

fanshan commented 5 months ago

Is not easer or cleaner, you change the logic. We don’t update the webhook if it exists.

Le 17 mai 2024 à 10:50, David Delassus @.***> a écrit :

update_or_create was easier and clearer than:

filter if found create else filter+update — Reply to this email directly, view it on GitHub https://github.com/SaaShup/netbox-docker-plugin/pull/129#issuecomment-2117065317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPE3XYHXHU2IQAELZYDE7LZCXAGLAVCNFSM6AAAAABH2P7LLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJXGA3DKMZRG4. You are receiving this because your review was requested.