SaaShup / netbox-docker-plugin

Netbox Docker Plugin
https://saashup.com
BSD 3-Clause "New" or "Revised" License
64 stars 5 forks source link

:zap: prevent exec on non running container #138

Open lvenier opened 5 months ago

lvenier commented 5 months ago
Netbox version Plugin Version Agent version Docker API Version
4.* 2.* * *

Actual Behavior

It is possible to run exec command on a non running container :

image

Desired Behavior

if the container is not running we should prevent to run exec command on the container :

image

amrutharajashekar commented 5 months ago

I would like to work on this issue , could you assign this to me. Thanks!.

lvenier commented 5 months ago

I would like to work on this issue , could you assign this to me. Thanks!.

This is yours. thanks for your support.

lvenier commented 4 months ago

I would like to work on this issue , could you assign this to me. Thanks!.

@amrutharajashekar : any help needed ?

amrutharajashekar commented 4 months ago

Hi Really sorry i did not get time to work on this , some one else can pick this up ?

lvenier commented 4 months ago

Hi Really sorry i did not get time to work on this , some one else can pick this up ?

No urgency. I was just asking in case you were struggling to implement it.