Saaras859 / ByteJam

W repo rizz
Apache License 2.0
0 stars 0 forks source link

Binary CPT Project Final Review #1

Open srivaidyas opened 6 months ago

srivaidyas commented 6 months ago

Binary Project Review

Team

Score Project Part Commits Video
0.9 Binary Blackjack Commits Video
Total Score
1.95/2

Sri Vaidya S

Score Project Part Commits Video
0.9 Confetti upon winning Commits Video

What I did... Austin, Cayden and I worked on the binary blackjack project. We split roles accordingly, the feature I mostly worked on was the confetti feature which pops confetti all over the screen once the player wins a game. I also worked on making and editing the video for the team which is to be presented as well.

Confetti Feature The confetti is a set of shapes pre-defined by CSS. The colors of them are randomly assigned with the number of confetti set to 150 each round. The confetti is set off by an if-then statement which triggers the confetti once the player wins any game. The JS script works by assigning 150 random shapes with random colors once the player wins and their position is set to the top of the screen. The shapes fall which creates a cool confetti effect once the player wins.

What I could have done if I had more time I would have worked on improving the confetti overall, although this was a small code, the level of bugs was pretty high. A few examples include how the confetti just randomly form at the top of the page, but I've temporarily fixed it by setting a time limit to clear the confetti after each round. It also gets pretty slow after consecutive wins, the confetti either get stuck or just vanish 1/3rd through the page.

Saaras Kondali & Eric Yu

Score Project Part Commits Video
0.9 Binary Blackjack Commits Video

We noticed that our website design was lacking and was slightly boring so in order to fix that what we were able to do. Is talk to Lopez and set up animations. We used a technology called keyframes in order to do this which allowed for text to be flipped in a markdown box.

Austin Zhang

Score Project Part Commits Video
0.9/0.9 Binary Blackjack Commits Video

I coded the entire game, and the rest of the team added little features to my base. I coded Javascript functions for the entire game, from generating random cards to comparing the scores at the end. I also coded functions to convert between decimal and binary.

Cayden Shi

Score Project Part Commits Video
0.88 Binary Blackjack Commits Video

While Austin worked on the base for the logic and function side of the code, I worked on the main base css section of the code. I coded the main base css for the website, creating buttons, and coding the layout for the site. Going a little more in depth, I coded the background, empty buttons, original fonts (changed by other team members), etc.

srivaidyas commented 6 months ago

Team Video Link Video

Harkirat47 commented 6 months ago

Team Review "Scrum Master A" grading "Scrum Master B"

Team Review ticket containing key Team and individual contributions

Improvements: Game itself was quite simple, could have added more complicated elements.

Harkirat47 commented 6 months ago

Individual Review Harkirat H grading Eric Yu

Individuals Video, Issue(s), Commits(s)

Improvements: Should have expanded on what he worked on, as he only worked on animations.

KaramKambo commented 6 months ago

Individual Review Karam K grading Austin Z

[ x] Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

[ x] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute [ x] Issue(s) that show plans/progress to team objectives [ x] Highlights of key commit(s) in Issues, summarizes code contributions [ x] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks

Per check. 0.9 above and beyond.

Freeform comment. Was a hard worker for this project. Coded all of the logic in javascript for the Binary Blackjack game. Made functions in javascript for the game itself, for comparing scores, for generating cards, and for converting between binary and decimal.

Improvements: Could have made it so that you could hide the dealers cards.

danielchoi2008 commented 6 months ago

Individual Review Daniel C grading Cayden S

[x] Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

[ x] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute [ x] Issue(s) that show plans/progress to team objectives [ x] Highlights of key commit(s) in Issues, summarizes code contributions [ x] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks

Per check. 0.9/0.9

My review: Overall, enjoyed their premise behind the project. The project was well thought out and the app worked as intended. Pretty cool. Cayden worked on the main CSS base which everyone else built off of. He coded the base visuals of the program to make it look flashy.

Improvements: Cayden should have worked a little on the Javascript as he focused most on the CSS.

jntpham commented 6 months ago

Individual Grading Jordan P grading Sri S

[ x]Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.

Individuals Video, Issue(s), Commits(s)

[ x] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute [ x] Issue(s) that show plans/progress to team objectives [ x] Highlights of key commit(s) in Issues, summarizes code contributions [ x] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks

Per check. 0.9 above and beyond.

Freeform comment. The confetti after you win binary blackjack is cool to watch! Shows good use and proficiency in CSS. Good job on the project!

Improvements: Even though the confetti was super cool, I think he should have had a little more impact on the overall project.