SaashaJoshi / piQture

piQture: A quantum machine learning library for image processing.
https://saashajoshi.github.io/piQture/
Apache License 2.0
20 stars 10 forks source link

Rename 'dims' to a suitable variable #5

Closed SaashaJoshi closed 9 months ago

SaashaJoshi commented 10 months ago

https://github.com/SaashaJoshi/quantum-image-processing/blob/20633e9d57bc3f3c341854ee26573a6e17adf9a6/quantum_image_processing/models/tensor_network_circuits/ttn.py#L19-L20

img_dim variable is used to store the product of the dimensions of an image. For example, for a 2x2 image, img _dim = 4. However, the above initialization of the class TTN (and, also MERA) doesn't explain what img_dim is or how it is used in the entire code. Perhaps, instead, this variable should be renamed to qubits or something better.