SabaAhmad404 / javascript-capstone

6 stars 1 forks source link

Code Review-First project #21

Open SabaAhmad404 opened 1 year ago

SabaAhmad404 commented 1 year ago

Kindly check our Kanban-board

  1. https://github.com/SabaAhmad404/javascript-capstone/projects/2
  2. We are a group of Three people .
tresorsawasawa commented 1 year ago

STATUS: REQUIRED CHANGES :recycle::recycle:

Hi @SabaAhmad404, @george827, and @Hassaanjbaig-code Good job so far! I know you worked hard to implement this project, I really appreciate the effort you put in! But there are some issues that you still need to work on to go to the next project but you are almost there!

almost-there

Required changes :recycle: :recycle:

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please ping me @tresorsawasawa when you comment so I can receive the notification or use slack with the same name.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Owusu-Desmond commented 1 year ago

Hi @SabaAhmad404 @george827 @Hassaanjbaig-code ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! πŸŽ‰

Highlights

πŸ“Œ Great working on the setup of the project kanban boardβœ…

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.