SabakiHQ / LeelaSabaki

Leela (Zero) integration with Sabaki.
MIT License
153 stars 35 forks source link

Ignore additional --gtp flag #7

Closed Atarust closed 6 years ago

Atarust commented 6 years ago

Error message is shown when trying to play with leelaSabaki:

"Current board arrangement can’t be recreated on the GTP engine."

Engine is called with: path: my_path/leelasabaki-linux arguments: my_path/leelaz --gtp -w my_path/weights.txt --playouts 10 --noponder

Playing with leelaz without leelasabaki-linux works fine. Using sabaki-v0.33.2-linux-x64.AppImage with leelsabaki-v0.3.0-linux-macos-win-x64.7z under ubuntu.

What am I doing wrong?

yishn commented 6 years ago

That's an interesting bug... but I can't reproduce this on my Windows machine. If Sabaki works with leelaz, but not with LeelaSabaki, there's definitely something wrong. Did you load some SGF file and start playing in the middle of the game? If so, can you provide it? Also, see if omitting the --gtp flag does something.

Atarust commented 6 years ago

wow. that's it. It works.

Without the --gtp it works. Thank you.

Could you add those example path and argument lines to the readme?

path: my_path/leelasabaki-linux
Arguments: --heatmap my_path/leelaz -w my_path/weights.txt --playouts 100 --noponder
yishn commented 6 years ago

Good idea!

BorisNA commented 6 years ago

It looks like I've got the same issue. Windows, Sabaki 0.33.3. LeelaZ and Leela 0.11.

For example, for LeelaZ. GTP works Ok according to the console, but the error "Current board arrangement..." still appears.

path: c:\_MyPrograms\LeelaZ\leelaz.exe 
Arguments: -w weights.txt --playouts 100 --noponder

Leela without weights file (if the path should be absolute) - the same result.

P.S. I've got it. Plain vanilla leela requires "--gtp" and the "leelasabaki" - doesn't. I believe that is the source of confusion. May be it will be a better solution to add a code to strip or ignore "--gtp" part for the leelasabaki?

yishn commented 6 years ago

I've got it. Plain vanilla leela requires "--gtp" and the "leelasabaki" - doesn't. I believe that is the source of confusion. May be it will be a better solution to add a code to strip or ignore "--gtp" part for the leelasabaki?

You're exactly right. That's a good idea! I'll keep this open for the suggestion.

WarChimp commented 6 years ago

I am also getting the same error

"Current board arrangement can’t be recreated on the GTP engine."

I am on a windows 7 machine using Sabaki 0.33.3 I can't seem to work out what the issue is. Here is a screenshot of my command line.

image

Here is the error I am getting when I boot a game with LeelaZero image

Am I missing something obvious?

yishn commented 6 years ago

@WarChimp It seems like you're not passing the path to Leela as an argument, but the path to LeelaSabaki.

yishn commented 6 years ago

This has been fixed in master.