search

SabakiHQ / Sabaki

An elegant Go board and SGF editor for a more civilized age.
https://sabaki.yichuanshen.de/
MIT License
2.39k stars 375 forks source link

The last move indicator broke when using any theme in version 0.52.1 or 0.52.2 #904

Open pavelwatson opened 2 years ago

pavelwatson commented 2 years ago

With any custom theme, this is how the last move indicator looks after updating Sabaki to version 0.52.2 from version 0.52.0

PelleasGo commented 1 year ago

I ran into this issue too. It applies to the Baduktv and Happy Stones themes, but not Kifu and Hikaru. I tried uninstalling and reinstalling the affected themes without luck.

apetresc commented 1 year ago

Ah thanks for pointing out a concrete theme - I had tried reproducing with the two or three themes I had installed and was unable to. I'll checkout the BadukTV and HappyStones themes ASAP and see if I can get to the bottom of it! 🙂

apetresc commented 1 year ago

So, interestingly enough, that style is actually there: https://github.com/upsided/Upsided-Sabaki-Themes/blob/64f9e6410215394eafc0048ba8f45a1da16b2445/happy-stones/styles.css#L70-L72. Removing that style fixes the issue.

I have no idea why it's there to begin with, I'll have to investigate the DOM on an older version and see how it was treated there. I suspect it has something to do with the changes in Shudan v1.7.0.

pavelwatson commented 1 year ago

so it's been about half a year there is till no fix 😔