search

SabakiHQ / Sabaki

An elegant Go board and SGF editor for a more civilized age.
https://sabaki.yichuanshen.de/
MIT License
2.39k stars 375 forks source link

Feature request: support the DD markup property #906

Open Trevoke opened 2 years ago

Trevoke commented 2 years ago

SGF has the ability to dim specific points/a region on the board ( https://www.red-bean.com/sgf/properties.html#DD ) and it would be very nice if that were supported by Sabaki!

As far as I can tell, this (and maybe SL, "selected points with unknown markup type") are the only two markup types from the SGF standard not yet supported by sabaki.

HackYardo commented 2 years ago

Is it possible to program a SGF markup system, so that users can add or delete their own markup symbols, i.e. any unicode char?

Trevoke commented 2 years ago

The "text" property lets people add arbitrary text labels of a few characters, if that helps. In Sabaki it's "select the A then shift+click" if I recall correctly.

Is this close to what you want?

--

Aldric. Sent from a mobile device.

On Tue, Sep 13, 2022, 07:34 Ya Tienna @.***> wrote:

Is it possible to program a SGF markup system, so that users can add or delete their own markup symbols, i.e. any unicode char?

— Reply to this email directly, view it on GitHub https://github.com/SabakiHQ/Sabaki/issues/906#issuecomment-1245282011, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQSSOUBATXJTMTCSNXNKTV6BRD3ANCNFSM6AAAAAAQJLB36I . You are receiving this because you authored the thread.Message ID: @.***>

Trevoke commented 2 years ago

Also your request is definitely not related to the first one, so if this doesn't help you, I'd suggest opening a new issue so both concerns can be handled separately.

--

Aldric. Sent from a mobile device.

On Tue, Sep 13, 2022, 07:38 Aldric @.***> wrote:

The "text" property let's people add arbitrary text labels of a few characters, if that helps. In Sabaki it's "select the A then shift+click" if I recall correctly.

Is this close to what you want?

--

Aldric. Sent from a mobile device.

On Tue, Sep 13, 2022, 07:34 Ya Tienna @.***> wrote:

Is it possible to program a SGF markup system, so that users can add or delete their own markup symbols, i.e. any unicode char?

— Reply to this email directly, view it on GitHub https://github.com/SabakiHQ/Sabaki/issues/906#issuecomment-1245282011, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQSSOUBATXJTMTCSNXNKTV6BRD3ANCNFSM6AAAAAAQJLB36I . You are receiving this because you authored the thread.Message ID: @.***>

apetresc commented 2 years ago

I don't believe we support the VW property (which is related to the DD property) either, but that one seems quite a bit harder to implement than DD. DD should be doable, thanks for the suggestion 🙂

HackYardo commented 1 year ago

Be careful, they are different.

abaisero commented 1 year ago

bumping this to add a similar request, since it was already mentioned, and it's pretty similar to DD: it would be very nice if Sabaki had support for the SL property. I'm working on a webapp for whole-board problems, and need a way to indicate subsets of vertices; at first I was abusing other markers for this purpose, but that's a bit of a problem in its own right; I might have to switch to another editor just for this =(

HackYardo commented 1 year ago

@abaisero other editor? what is it? q5Go or Ogatak? Which editor supports all sgf properties?

abaisero commented 1 year ago

Not sure, I wouldn't expect a single editor to support all the properties; I was just implying potentially making use of another editor exclusively to set the SL property only. But it seems like the SL property is old and not very supported so who even knows which editors support it. As another alternative, I might end up just abusing the other markups to achieve a similar goal.