Open RobertChrist opened 1 year ago
Hey, no worries! I'm happy to hear from ya : D
You are right that 'Toggle Show Comments' is a little bit of an odd duck here. I thought the same when I added it, which is why I added it as its own menu item, and put it in its own section group.
You're the maintainer of the app, if you think it makes sense to remove go for it!
I do like the idea of keeping something in this menu, though : ) The reason, is because it took me a long time to learn that adding a comment to a node changes the color, or that one can only see said comments if the comment mode is on. I really liked the idea that by adding all of these options to the right context menu it naturally leads the user to become aware of all the functionality that can edit the color of a game node.
But I agree that toggling a global state from a node specific menu is a bit weird.
Sitting here now, I'm wondering if maybe the best option would be to remove the 'Toggle Show Comments' option as you suggest, but add a new option to the Annotate menu called 'Add/View Comment'? This would be a node specific option, and could enable the Show Comments mode if it was not already enabled (thereby helping user feature discovery). We could always do that in a future branch as well, of course
Implements https://github.com/SabakiHQ/Sabaki/issues/940