cryptsetup hangs because dmsetup is not included with LUKS="yes" and LVM="no"

Sabayon / genkernel-next

An improved and modern remake of Gentoo genkernel (in: udev, plymouth; out: cross compiler support)

47 stars 45 forks source link

cryptsetup hangs because dmsetup is not included with LUKS="yes" and LVM="no" #48

Closed sbraz closed 7 years ago

sbraz commented 7 years ago

Hi, I have an encrypted root partition and no LVM but I had to select LVM="yes" in order to make my system bootable. I think LUKS="yes" should cause genkernel to include /sbin/dmsetup in the initramfs as cryptsetup depends on it. After looking at gen_initramfs.sh, I didn't see any other missing binaries.

mudler commented 7 years ago

Hi! thanks for reporting. can you investigate if it's just dmsetup required or other components as well? cryptsetup requires lvm2 utilities. otherwise seems reasonable to me for now to imply LVM="yes" when LUKS is requested.

sbraz commented 7 years ago

I'll try editing the .sh to just add dmsetup and I'll let you know tonight.

sbraz commented 7 years ago

Just adding dmsetup wasn't enough. It was still hanging. I guess it's reasonable to include LVM when LUKS is set. Maybe you want to add a comment explaining that in the conf file?

mudler commented 7 years ago

Thanks for confirming, don't think it's necessary, now it's done automatically when LUKS is enabled https://github.com/Sabayon/genkernel-next/commit/ccedb7524aabe256827538f5ca532319d520872e but feel free to open a PR for the config changes.

I'll close the issue now, re-open if necessary.