search

Sabayon / sabayon-website-next

Sabayon next website
https://next.sabayon.org
5 stars 3 forks source link

AMDGPU blog #54

Closed jcfrosty closed 7 years ago

jcfrosty commented 7 years ago

this is my first time attempting to add to the blog. Can someone please double check my work?

Ryuno-Ki commented 7 years ago

Hi, @jcfrosty!

Could you tell me, why you closed this PR?

jcfrosty commented 7 years ago

I didn't? Or at least I didn't mean to? I'm trying to correct the problems you listed currently.

On Mon, Jun 26, 2017, 12:01 PM André Jaenisch notifications@github.com wrote:

Hi, @jcfrosty https://github.com/jcfrosty!

Could you tell me, why you closed this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Sabayon/sabayon-website-next/pull/54#issuecomment-311120021, or mute the thread https://github.com/notifications/unsubscribe-auth/ANERGQOis4KQjkes8M7CNZmv_c3Bac3Nks5sH-PqgaJpZM4OEGqZ .

jcfrosty commented 7 years ago

Sorry for the mess. as you can tell, I'm not completely familiar with github yet. I'm learning ;)

https://github.com/Sabayon/sabayon-website-next/pull/55

Enlik commented 7 years ago

General comment: I enjoyed the read but my feel is that the article is more technical (due to vocabulary and style being used), I could said nerdy, and can be harder by the less technical ones, or can leave readers with less knowledge of the video/GPU ecosystem some questions.

By itself, this is not a bad thing, especially given that it's signed by your name (meaning the style /can/ be personal as I think of it), and in my option it could be left as is, but you might keep this in mind when writing futher articles on the website. (I'm not for dumbing down content; reading something like this actually allows someone to learn from it which is great, so take what I wrote with a grain of salt.)

Enlik commented 7 years ago

Sorry for the mess. as you can tell, I'm not completely familiar with github yet. I'm learning ;)

This one could be reopened instead, to keep everything in one place. Please do this like this in the future.

jcfrosty commented 7 years ago

Glad you liked it. Yeah, I figured the only people who would be interested in the AMDGPU blog would be people with an AMD card looking for answers (both techy and non). I don't plan on them all being techy, but there are those who are upset with AMD in general and I felt they deserved some sort of explanation. Even if it was a little over the top, they could still get something out of it.

I'll keep in mind the ability to reopen next time. I was looking at the closed image at the top and looking to see if I could click it and get it to reopen, but it doesn't work that way. I just noticed the "reopen and comment" button on the bottom. I should have checked that before opening a new one.

Enlik commented 7 years ago

Changing "radeon" to something like "the radeon driver" should make it much easier for those non-AMD device owners in the following sentence.

"Some of you may still be using radeon on +AMD HD7XXX or R9 2XX (SI/CIK) video cards."

jcfrosty commented 7 years ago

Good point, also fixed.