search

SaberLLC / Saber-Factions

The Ultimate Factions Plugin
GNU General Public License v3.0
121 stars 99 forks source link

Server Crash #184

Closed ghost closed 1 year ago

ghost commented 2 years ago

Describe the bug Once in a while my logs are getting spammed with the messages i attached. This time it was so bad, my Server crashed

To Reproduce Steps to reproduce the behavior: Its not everyday, I have seen this message 3 times befor but it never crashed my server.

Server Version (please complete the following information):

I have shorten the log, the error startet at 06:06 and "ended" at 06:54 by killing my Server.

Log: https://pastebin.com/ubWXWC

2021-09-29-1.log

SoRadGaming commented 2 years ago

It seems the plugin uses a deprecated method registerNewObjective that is causing the issue, I have compiled a potential fix, try it and tell me if it works. SaberFactions#184.zip

ghost commented 2 years ago

Thanks, i will test it.

ghost commented 2 years ago

I didnt used the jar on my test server, not on my productive server. The error never came on my test server...

I got the same error with the latest Saber Faction Build v1.6.9.5-2.9.6-RC

latest20211015.log

[08:07:11] [Server thread/WARN]: [Factions] Task #247624 for Factions v1.6.9.5-2.9.6-RC generated an exception java.lang.IllegalArgumentException: An objective of name '16d6ef0090321b_0' already exists at org.apache.commons.lang.Validate.isTrue(Validate.java:136) ~[patched_1.17.1.jar:git-Airplane-95] at org.bukkit.craftbukkit.v1_17_R1.scoreboard.CraftScoreboard.registerNewObjective(CraftScoreboard.java:46) ~[patched_1.17.1.jar:git-Airplane-95] at org.bukkit.craftbukkit.v1_17_R1.scoreboard.CraftScoreboard.registerNewObjective(CraftScoreboard.java:86) ~[patched_1.17.1.jar:git-Airplane-95] at org.bukkit.craftbukkit.v1_17_R1.scor oard.CraftScoreboard.registerNewObjective(CraftScoreboard.java:61) ~[patched_1.17.1.jar:git-Airplane-95] at org.bukkit.craftbukkit.v1_17_R1.scoreboard.CraftScoreboard.registerNewObjective(CraftScoreboard.java:29) ~[patched_1.17.1.jar:git-Airplane-95] at org.bukkit.craftbukkit.v1_17_R1.scoreboard.CraftScoreboard.registerNewObjective(CraftScoreboard.java:19) ~[patched_1.17.1.jar:git-Airplane-95] at com.massivecraft.factions.scoreboards.BufferedObjective.flip(BufferedObjective.java:117) ~[SaberFactions.jar:?] at com.massivecraft.factions.scoreboards.FScoreboard.updateObjective(FScoreboard.java:156) ~[SaberFactions.jar:?] at com.massivecraft.factions.scoreboards.FScoreboard.access$300(FScoreboard.java:15) ~[SaberFactions.jar:?] at com.massivecraft.factions.scoreboards.FScoreboard$1.run(FScoreboard.java:119) ~[SaberFactions.jar:?] at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[patched_1.17.1.jar:git-Airplane-95] at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) ~[patched_1.17.1.jar:git-Airplane-95] at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1559) ~[patched_1.17.1.jar:git-Airplane-95] at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:492) ~[patched_1.17.1.jar:git-Airplane-95] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1475) ~[patched_1.17.1.jar:git-Airplane-95] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1274) ~[patched_1.17.1.jar:git-Airplane-95] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[patched_1.17.1.jar:git-Airplane-95] at java.lang.Thread.run(Thread.java:831) ~[?:?]

Driftay commented 2 years ago

1.17 changed their api in a crucial matter that deals with sidebars

I am going to have to find a workaround in the meantime

ghost commented 2 years ago

Just a quick feedback. I'm still getting this error with the new 3.0.0 version.

Driftay commented 2 years ago

Just a quick feedback. I'm still getting this error with the new 3.0.0 version.

can you show me your scoreboard config?

ghost commented 2 years ago

This is my config.yml

config.txt

(I edit it to txt because I cant upload .yml files)