SaberLLC / Saber-Factions

The Ultimate Factions Plugin
GNU General Public License v3.0
121 stars 99 forks source link

Feature Request - Add Truce and Ally relation to FriendlyFire #225

Open ghost opened 1 year ago

ghost commented 1 year ago

Is your feature request related to a problem? Please describe. FriendlyFire is only toggleable for faction members inside a faction, TRUCE and ALLY relations are unaffected by this and FriendlyFire remains disabled, no matter the settings. (Yes this also happens when ff is toggled via API)

Describe the solution you'd like Either make TRUCE and ALLY relation be affected by FriendlyFire settings or add a seperate way for these relations to toggle friendlyfire. Would be much appreciated.

Describe alternatives you've considered I've considered trying to find the codesection where that damage is cancelled, altering it and submitting a pr but this sourcecode is old so I have no Idea if that even makes any sense to do.