SabineWren / Quiver

Hunter addon for World of Warcraft 1.12.1
GNU Affero General Public License v3.0
26 stars 7 forks source link

Range indicator is incorrect. #21

Closed rgswords closed 3 weeks ago

rgswords commented 3 weeks ago

image

As you can see, this is NOT melee range. Incorrect value whether locked or unlocked, for all targets.

SabineWren commented 3 weeks ago

It works for my level 1 test character. How do you reproduce that?

Screenshot from 2024-09-07 23-22-52

SabineWren commented 3 weeks ago

Do you have ranged macros with the wing clip texture?

rgswords commented 3 weeks ago

I do have a macro with the Wing Clip texture, but it's melee abilities: Wing Clip and Raptor Strike.

SabineWren commented 3 weeks ago

Does it still happen without that macro on your bars? What about on a level 1 hunter?

rgswords commented 3 weeks ago

Taking the macro off the main bar apparently fixes the behavior in showing the correct ranges as I move towards and away from the target. Aside from that, there are no melee abilities/icons on any of my bars. The macro itself uses the Wing Clip icon and is a simple spammable: /cast Raptor Strike /cast Wing Clip

Unfortunately I do not have room for a level 1 on this account. Please let me know if you have additional test cases.

SabineWren commented 3 weeks ago

Interesting... despite the action bar icon visibly changing based on macro contents, it seems GetActionTexture(slot) returns the initial texture set in the macro menu. The range check requires finding the spell on an action bar slot by texture. I'm able to create false positives by setting the initial texture to Wing Clip (Rogue Trip), then setting the macro to /cast Aimed Shot.

SabineWren commented 3 weeks ago

This isn't intuitive behavior. I could change it back to only looking at raw spells instead of macros.

SabineWren commented 3 weeks ago

Still confused, since I can't replicate any of the points you mentioned. The macro either has a range-checked texture + any spell in range, or it doesn't. Regardless, requiring raw spellbook abilities on the action bar gives much more consistent behavior.

SabineWren commented 3 weeks ago

Fixed on release branch e281abda6fce4db282683aa7f07b0781ab9c3bd4