SabineWren / Quiver

Hunter addon for World of Warcraft 1.12.1
GNU Affero General Public License v3.0
30 stars 7 forks source link

Added throw, lol #9

Closed Jan125 closed 10 months ago

Jan125 commented 10 months ago

Added throw, roflmao

SabineWren commented 10 months ago

I've never considered thrown weapons before. They break the range indicator since they don't work with serpent sting, but that's fixable by checking the Throw action instead.

The purpose of no-clip macros is for castable shots to not interrupt Auto Shot. Throw replaces Auto Shot entirely, and it can't clip Auto Shot when it is the auto shot. I don't understand what a no-clipping Throw command would do.

I don't see an issue on the Twow bug tracker about thrown weapons and multi-shot. Is it intended to only work with rank 1 multi-shot? I don't want to add a dedicated rank 1 kludge to Quiver if Twow will patch it to work with other ranks.

SabineWren commented 10 months ago

How about exposing the no-clip logic to macros instead? Then it doesn't matter what Turtle does with thrown weapons.

/script Quiver_Cast_No_Clip("Multi-Shot(Rank 1)");
Jan125 commented 10 months ago

I've never considered thrown weapons before. They break the range indicator since they don't work with serpent sting, but that's fixable by checking the Throw action instead.

Just a simple question, is rangechecking Auto Shot not possible? Because of it currently being active? An alternative could also be Scorpid Sting, since that works with everything.

The purpose of no-clip macros is for castable shots to not interrupt Auto Shot. Throw replaces Auto Shot entirely, and it can't clip Auto Shot when it is the auto shot. I don't understand what a no-clipping Throw command would do.

Wrong. On Turtle, Auto Shot works with thrown weapons, you can weave Throw in between the shots. Throw itself has a 0.5s cast time.

I don't see an issue on the Twow bug tracker about thrown weapons and multi-shot. Is it intended to only work with rank 1 multi-shot? I don't want to add a dedicated rank 1 kludge to Quiver if Twow will patch it to work with other ranks.

It's been this way since over a year, so I suppose so. There have been multiple forum posts about this. The number of hunters using thrown weapons is probably too low for them to bother fixing/unifying the spells.

How about exposing the no-clip logic to macros instead? Then it doesn't matter what Turtle does with thrown weapons.

/script Quiver_Cast_No_Clip("Multi-Shot(Rank 1)");

That'd work as well.

SabineWren commented 10 months ago

I squash-merged it for now and opened https://github.com/slowtorta/turtlewow-bug-tracker/issues/5985 Will base further updates on the results of that issue.

SabineWren commented 9 months ago

Reverted the merge for two reasons:

  1. From private conversation with Twow devs, a future patch will break this code, so Quiver support for throwing weapons is a dead end effort.
  2. This commit expects 'throw' to appear on action bars, otherwise outputting a warning to chat frame. It would take additional code to check that a throwing weapon is equipped and adjust expected spells accordingly.