search

SabineWren / wow-api-type-definitions

Lua type definitions for WoW 1.12.1
GNU General Public License v3.0
5 stars 2 forks source link

Documentation related to keybindings #5

Closed imbus64 closed 1 month ago

imbus64 commented 1 month ago

Almost certainly contains errors. Specifically, im unsure about some of the return types. Tried to put this in a suitable place, feel free to rearrange as needed.

SabineWren commented 1 month ago

Please put these in a file called KeyBinding.d.lua and I'll merge it. That's consistent with the wowpedia categories.

Have you used MultiActionBar_Update? The function exists in game, but I don't see it documented anywhere. It looks related to Action functions.

imbus64 commented 1 month ago

Good idea. Could you glance over the return types as well? Im pretty sure one of GetBinding/GetBindingKey has the wrong annotation (array vs tuple).

The multiactionbar functionality might be from a later version, so i removed it for now. I did not do much testing, quite possibly a no-op in the earlier versions. I choose these functions because i use them in a personal hotkey script i maintain for different versions.

Other than the return annotations, things should be in order now.

SabineWren commented 1 month ago

Follow-up fixes variadic returns and missing functions 9dfa94faccf2800cb5563cb8706ebc7526c49e1c