Sabissimo / AssistantEnabler

[Xposed module] Enable Google Assistant in Marshmallow ROMs http://repo.xposed.info/module/com.sabik.assistantenabler
BSD 3-Clause "New" or "Revised" License
16 stars 8 forks source link

Cannot disable Assistant from Google app settings #13

Closed alice-mkh closed 7 years ago

alice-mkh commented 7 years ago

It seems that if we stop spoofing opa_enabled value in config file, then the Assistant still works, but can be disabled the normal way. In this case, if you try to summon it, it looks like this: screenshot_20170108-012800 Translation: Google Assistant is disabled. Enable? No | Yes As you can see, the Assistant is properly disabled in the settings. If I turn it on either via the Yes button, or via settings, it functions normally. I would do pull request for this, but I haven't properly tested what will happen on a clean install of the module: it's possible that it only allows this because I already had it enabled on this device. Either way, you might be interested in this.

Sabissimo commented 7 years ago

Tested it on clean install of the module, and it does indeed work. Merged it into repo and pushed new version out. Thanks!

P.S. Можешь писать и по-русски ;-)

alice-mkh commented 7 years ago

Хм, ладно. Но вообще я обычно на англоязычных сайтах по-русски не пишу, все-таки тут и другие люди есть. Баг закрываю, раз всё нормально.