search

Sable / Ostrich

Benchmark suite for studying the performance of JavaScript and WebCL for numerical computation
Other
24 stars 12 forks source link

xi_sum initialization js #36

Closed pjots closed 7 years ago

pjots commented 7 years ago

File : bwa_hmm.js

Line 51: var xi_sum;

Line 457: xi_sum = new Array(nstates*nstates); \ 2D array stored as 1D array \ in case of nota, Array replaces Float32Array, and memory is initialized to undefined instead of 0

Line 268: for(t=0; t<nstates;++t)xi_sum[t]=0; \ xi_sum is initialized to zero only for only one row (nstates), whereas it should be initialized for all rows (nstates * nstates)

elavoie commented 7 years ago

Hi Prabhjot, could you first create a separate repository for the HMM benchmark named 'hmm-benchmark'? See the backprop as an example: https://github.com/Sable/backprop-benchmark of how to make it compatible with Wu-Wei.

Use the original code (the one from Ostrich here) for it. Then commit your changes in a separate branch on the hmm-benchmark repository and do a Pull-Request. That will be a lot easier for me to review the changes as I will have a diff of everything you modified.

Then explain in the comments of the Pull-Request what is it that you want me to review specifically and what you need confirmation on.

After we will be done we will have an updated version of hmm with your bug fix that everyone can use with the latest version of Wu-Wei.