SabreTools / BinaryObjectScanner

C# protection, packer, and archive scanning library
MIT License
82 stars 13 forks source link

System Shock 2 .mc files causing copy protection scan to hang. #292

Open Randy2727 opened 3 months ago

Randy2727 commented 3 months ago

MPF hangs on the copy protection scan of a dump of System Shock 2 on the file aracdyng_.mc that is contained in the archive? motions.crf.

Testing an extracted aracdyng_.mc with BOS test.exe outputs File format found: BSP

aracdyng_.zip

mnadareski commented 3 months ago

This is definitely a BSP file based on everything I can find internally. Unfortunately, the value that it's getting for the number of textures is 1065332325, which seems a bit high.

mnadareski commented 3 months ago

For now, the serialization library will cut off if it runs past the end of the file instead of just trying to build blindly. Unfortunately, what this will likely need is a special bit of handling for BSP v30 files that are specialized for System Shock 2.

mnadareski commented 2 months ago

Newest BOS rolling release (https://github.com/SabreTools/BinaryObjectScanner/releases/tag/rolling) includes the changes above. Please test when possible.