[Bug] Some Sysiphus discs cause BoS to hang

SabreTools / BinaryObjectScanner

C# protection, packer, and archive scanning library

MIT License

88 stars 13 forks source link

[Bug] Some Sysiphus discs cause BoS to hang #334

Open HeroponRikiBestest opened 2 days ago

HeroponRikiBestest commented 2 days ago

Some Sysiphus discs cause BoS to hang due to ring protection resulting in 0x55 that's interpreted as a giant string of 'U', causing pex.overlays to hang forever.

Examples: http://redump.org/disc/39126/ , http://redump.org/disc/100528/ Files: Ironstorm.ocd.zip Dame_xxl.cab.zip

mnadareski commented 2 days ago

Implementation notes:

Will need to be updated in Serialization
A reasonable cap value for repeated characters needs to be established before it's thrown out (64)

mnadareski commented 2 days ago

Any string of a single character 64 times will now be discarded in Serialization: https://github.com/SabreTools/SabreTools.Serialization/commit/700b0359ea6db0b2ff769ad57f22c4d974666447

This has not been updated in BOS yet, so this item will remain open until then.