search

SabreTools / BinaryObjectScanner

C# protection, packer, and archive scanning library
MIT License
92 stars 13 forks source link

Crash in SolidShield detection #64

Closed TheRogueArchivist closed 3 years ago

TheRogueArchivist commented 3 years ago

This file shouldn't contain SolidShield (but I'm not 100% sure). The crash is: 

  HResult=0x80131508
  Message=Index was outside the bounds of the array.
  Source=BurnOutSharp
  StackTrace:
   at BurnOutSharp.ProtectionType.SolidShield.CheckContents(String file, Byte[] fileContent, Boolean includeDebug) in C:\Users\silas\Desktop\GIT\BurnOutSharp\BurnOutSharp\ProtectionType\SolidShield.cs:line 170
   at BurnOutSharp.FileType.Executable.<>c__DisplayClass3_0.<Scan>b__0(IContentCheck contentCheckClass) in C:\Users\silas\Desktop\GIT\BurnOutSharp\BurnOutSharp\FileType\Executable.cs:line 102
   at System.Threading.Tasks.Parallel.<>c__DisplayClass42_0`2.<PartitionerForEachWorker>b__1()

The file is "Quake4.exe" (SHA1: B718AE36887C74A8A44750CAD2C001EE62B02AF0)

TheRogueArchivist commented 3 years ago

Still present as of newest commit.

  HResult=0x80131508
  Message=Index was outside the bounds of the array.
  Source=BurnOutSharp
  StackTrace:
   at BurnOutSharp.ProtectionType.SolidShield.CheckContents(String file, Byte[] fileContent, Boolean includeDebug) in C:\Users\silas\Desktop\GIT\BurnOutSharp\BurnOutSharp\ProtectionType\SolidShield.cs:line 123
   at BurnOutSharp.FileType.Executable.<>c__DisplayClass3_0.<Scan>b__0(IContentCheck contentCheckClass) in C:\Users\silas\Desktop\GIT\BurnOutSharp\BurnOutSharp\FileType\Executable.cs:line 101
   at System.Threading.Tasks.Parallel.<>c__DisplayClass42_0`2.<PartitionerForEachWorker>b__1()
TheRogueArchivist commented 3 years ago

Fixed as of newest commit.