SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
417 stars 34 forks source link

[Problem] Doesn't detect an incomplete redumper DVD dump #500

Closed DopefishJustin closed 1 year ago

DopefishJustin commented 1 year ago

Version

Build What runtime version are you using?

Describe the issue MPF does not seem to detect the redumper process terminating before it finishes, and proceeds as if the dump were successful.

To Reproduce Steps to reproduce the behavior:

  1. Insert a DVD (I used an IBM PC compatible one)
  2. Scan for discs
  3. Select redumper as the dumping program
  4. Begin a dump
  5. Click X to close the redumper console window
  6. Note that MPF continues with the protection check and the submission info window

Expected behavior Red text in the output window indicating a failure

Additional context Works as expected when dumping a CD with redumper.

mnadareski commented 1 year ago

This is going to be difficult because the only thing that MPF looks for in a "completed" dump is one that contains all of the files that are necessary. If Redumper is creating all files off the bat, then it will pretty much always say that it's "complete". Not sure how to get around this, to be honest. Leaving it open, though, because it is an issue.

mnadareski commented 1 year ago

Possibly fixed by https://github.com/SabreTools/MPF/commit/8a5475380a0c318ed34b74724ea300d67d04411e

DopefishJustin commented 1 year ago

Confirmed fixed in 8a547538