search

SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
432 stars 34 forks source link

[Problem] [Xbox 360] duplication of XeMID, DMI, etc. when verifying a disc #512

Closed mictlantecuhtle closed 1 year ago

mictlantecuhtle commented 1 year ago

Version

Build

Describe the issue When verifying an Xbox 360 disc, MPF both pulls the existing information for XeMID, DMI, PFI etc. from the comments and adds new information to those same fields. This can result in duplication as follows (for http://redump.org/disc/37091/):

<b>XeMID</b>: BS202201L02F11, BS202201L02F11
<b>DMI</b>: 8C70E948, D82C1B4D, BA9E12CE, 8C70E948
<b>PFI</b>: 26AF4C58, 26AF4C58
<b>SS</b>: 608E1DE8
<b>SS version</b>: 02
<b>SSv2</b>: 95E33438, 1DA16F23, BCA13B5C

To Reproduce Dump an Xbox 360 disc which is known to verify an existing entry using MPF and DiscImageCreator

Expected behavior It would be preferable for these cases if MPF did not pull existing information from the comments but rather only added information available from the dump logs themselves. As dumpers have to post verifications to the forum anyway, moderators can easily check and add new information to the existing entry