search

SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
417 stars 34 forks source link

[Problem] Able to select Redumper for HD DVD #514

Closed FoxhackDN closed 11 months ago

FoxhackDN commented 1 year ago

Version What version are you using?

Build What runtime version are you using?

Describe the issue If you select HD DVD as the system, then select redumper as the dumping program, the dump button is grayed out. That's proper behavior.

If you select a different supported dumping tool for the format (DIC or Aaru), the default command line parameters are loaded and the dump button works again. Also proper behavior.

But if you go and select redumper, the command line parameters box is blanked out, AND the dump button works. If you press it, nothing happens, Redumper says "Media and system combination not supported for Redumper". So the only bug here is the button not being grayed out like it's supposed to.

To Reproduce Steps to reproduce the behavior:

  1. Select Redumper
  2. Change media to HD DVD Video
  3. Change dumping tool from the selection box to DIC or aaru
  4. Change it back to Redumper

Expected behavior The button should be grayed out

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

FoxhackDN commented 11 months ago

Updating for 2.7.0, since recent changes have fixed some things:

  1. Set the Default System to "No System Selected", restart MPF if needed.
  2. You should see there's no default system selected, so the media type is grayed out.
  3. Select Redumper
  4. Change system to HD DVD Video, this will change the media type to HD-DVD Video as well.
  5. The dumping box is active, but the parameters box is empty.

If you click on "Start Dumping", MPF will create a folder in the path shown on the output path as normal but no files will be generated, because "Media and system combination not supported for Redumper" (which is the correct behavior.)

This also seems to happen if you have a default system selected in the options and you change to HD DVD Video.

mnadareski commented 11 months ago

Should be fixed by https://github.com/SabreTools/MPF/commit/ae326c1d2f9e973db7416ec01c65a7a48bbb2815 and https://github.com/SabreTools/MPF/commit/e8b0b3efaa463b0a726ec354d40b72aa942cc22c