search

SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
428 stars 34 forks source link

Fix serial parsing from #542 #549

Closed Deterous closed 1 year ago

Deterous commented 1 year ago

I tested the changes from #542 and they don't work as intended, a "SLPM-645xx" disc is registered as "Japan"

I believe it is because the serial string being passed to this function has a "-" in it, i.e. serial = "SLPM-64511", whereas I had initially assumed it would be "SLPM64511". Unfortunately I do not have the time to build MPF with this minor change to test this, so unless @mnadareski knows the string format of the serial being passed to this function, then this is the best I can do.

Otherwise, if it still doesn't work this function be simplified again to remove the serial-number parsing.

mnadareski commented 1 year ago

The serial is passed in as the executable name with all _ characters replaced by - and all . characters removed. I hope that helps.