[Problem] MPF.Check outputs PS5 disc size wrong as BD-33 instead of BD-66 in !submissionInfo.txt

[gmipf]

Before You Submit

Version

• [x] Stable release ( MPF.Check_3.0.0_net6.0_linux-x64_release.zip )
• [ ] WIP release (version here)

Build

• [x] .NET 6.0 running on (Fedora Linux 38)
• [ ] .NET 8.0 running on (Operating System)

Describe the issue A 2-layer PS5 disc is wrongfully described as a BD-33 in !submissionInfo.txt

To Reproduce Steps to reproduce the behavior: Dump a 2 layer PS5 disc in redumper, run mpf.check on that dump.

log: ps5_f23_ppsa06275.zip

[mnadareski]

The layerbreak information is missing from your logs. I'm gonna get @superg to look at this because it might be an issue from the Redumper side.

[mnadareski]

This appears to have been fixed by Redumper build 271. Please try that out and rerun your test. It should function as expected.

[gmipf]

Added new log, it is shown as BD-66 now on latest redumper + latest MPF.Check. But now there is a new problem. The disc wasn't detected in the redump db. MPF.Check output:

Credentials entered, will attempt Redump login...
Credentials accepted! Logged into Redump...
Redump username and password accepted!
Gathering submission information... please wait!
Extracting output information from output files...
Credentials entered, will attempt Redump login...
Credentials accepted! Logged into Redump...
Finding disc matches on Redump...
There were no matching IDs for track with SHA-1 of '<rom name="dump.iso" size="58367475712" crc="27239608" md5="7554e32bdd6fa4b5ea5b884412927631" sha1="29f68ac74aa3922b44d81db14bda329fa8774197" />'
Match finding complete! No matches found
Extracting information complete!
Processing site codes...
Processing complete!
Formatting information...
Formatting complete!
Writing information to !submissionInfo.txt...
Writing complete!
Submission information process complete!

ps5_f23.zip

PS: WTH even is skeleton in latest redumper? It took an extra while to end the dump.

[superg]

Added new log, it is shown as BD-66 now on latest redumper + latest MPF.Check. But now there is a new problem. The disc wasn't detected in the redump db. MPF.Check output:

Which disc do you expect it to match with?

PS: WTH even is skeleton in latest redumper? It took an extra while to end the dump.

It's an extra feature where we capture disc structure without any data. Useful for many things, mod can check the structure with IsoBuster, file dates, etc.

[Deterous]

But now there is a new problem. The disc wasn't detected in the redump db. MPF.Check output:

Credentials entered, will attempt Redump login...
Credentials accepted! Logged into Redump...
Redump username and password accepted!
Gathering submission information... please wait!
Extracting output information from output files...
Credentials entered, will attempt Redump login...
Credentials accepted! Logged into Redump...
Finding disc matches on Redump...
There were no matching IDs for track with SHA-1 of '<rom name="dump.iso" size="58367475712" crc="27239608" md5="7554e32bdd6fa4b5ea5b884412927631" sha1="29f68ac74aa3922b44d81db14bda329fa8774197" />'

Known issue, fixed already: https://github.com/SabreTools/MPF/commit/807b0c5f9e447bf32b259e96aa822d76a01b9664

[superg]

Ah, so it matches to FIFA, I thought there is still redumper issue where I don't generate proper iso.

[gmipf]

@superg Every BD dump since the addition of BD support matched with redumper. No problem there.

[mnadareski]

That is a separate issue that has already been fixed. Thank you for confirming.