search

SabreTools / MPF

Redumper/Aaru/DiscImageCreator GUI in C#
GNU General Public License v3.0
405 stars 34 forks source link

[Request] Read executable date from logs, if available #626

Closed mnadareski closed 6 months ago

mnadareski commented 6 months ago

In a long-standing complaint from a subset of moderators, the current MPF code takes executable dates for PS1 and PS2 directly from the executables themselves, adjusting to UTC to account for international dumpers. Previously, dumpers have used a combination of local datetimes (as seen in whatever timezone they are in) or from the logs provided by the dumping programs.

This request covers trying to read those executable dates from the provided logs as a primary source, falling back on the UTC date if either the date in the logs is invalid or the logs do not contain a date at all. This should help some of the confusion and frustration that the original change to UTC brought.

Deterous commented 6 months ago

What systems should this apply to? There are a lot of systems that have exe or build date in redump. MPF currently does at least PSX/PS2/KP2/GDROM/SEGACD/SATURN

mnadareski commented 6 months ago

Preferably all of the ones that look at a physical file for the date. At the very least that's PSX, PS2, and KP2. I believe the others come from internal values.